Add non-blocking buffer to interface with CRT #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
force-pushed
the
crt-buffer
branch
2 times, most recently
from
54c279f to
fe467f0
Compare
JordonPhillips
force-pushed
the
crt-buffer
branch
from
fe467f0 to
ebc7dcc
Compare
nateprewitt
approved these changes
Mar 7, 2025
alextwoods
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue we were having of the CRT not reading data. Basically the problem is that the CRT seemingly will close out if it ever receives empty bytes. Previously we were buffering with a BytesIO, and so the CRT would just immediately read that and call it a day.
On the other hand, if it receives a
BlockingIOErrorit'll just try again later. That's what the transcribe streaming sdk does too. So replaces the BytesIO buffer with one based on the transcribe buffer.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.